Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show booking date and time correctly on InboxPage #1194

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Show booking date and time correctly on InboxPage #1194

merged 3 commits into from
Sep 10, 2019

Conversation

OtterleyW
Copy link
Contributor

@OtterleyW OtterleyW commented Sep 9, 2019 •
edited
Loading

Screen Shot 2019-09-09 at 13 39 55
Screen Shot 2019-09-09 at 13 39 35
Screen Shot 2019-09-09 at 16 36 23

@OtterleyW OtterleyW force-pushed the show-time-on-inboxpage branch 2 times, most recently from a26a33d to 3cc7fb2 Compare September 9, 2019 10:05
@OtterleyW OtterleyW force-pushed the show-time-on-inboxpage branch 11 times, most recently from cf38aa7 to 20c826d Compare September 10, 2019 11:02
Gnito
Gnito reviewed Sep 10, 2019
View reviewed changes
src/components/BookingTimeInfo/BookingTimeInfo.js Outdated
</>
) : null;

return <div className={classNames(css.bookingInfo, bookingClassName)}>{dateInfo}</div>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, it might be more readable to return inside if - else if - else -structure.

Gnito
Gnito approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One readability comment.

@OtterleyW OtterleyW merged commit a707c4b into master Sep 10, 2019
@OtterleyW OtterleyW deleted the show-time-on-inboxpage branch September 10, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnito Gnito Gnito approved these changes

Assignees
No one assigned
Labels
review comments review ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OtterleyW @Gnito